Collect allocated storage for container projects #15973
Conversation
zeari
force-pushed
the
container_storage
branch
from
79a89a1 to
fc357cd
Compare
miq-bot
changed the title
zeari
force-pushed
the
container_storage
branch
from
fc357cd to
e215b22
Compare
| @@ -0,0 +1,17 @@ | |||
| module Metric::ContainerStorage | |||
| def self.fill_allocated_container_storage(obj) | |||
| volumes_or_claims = if obj.kind_of? ContainerGroup | |||
There was a problem hiding this comment.
IIRC @nimrodshn added pod => pvc relation too, so it might be simpler to use it here.
zeari
force-pushed
the
container_storage
branch
4 times, most recently
from
ce28029 to
0060000
Compare
| return {} if !obj.kind_of?(ContainerProject) | ||
|
|
||
| sum_storage = obj.persistent_volume_claims.inject(0) do |sum, volume| | ||
| sum + volume.capacity[:storage] if volume.capacity.present? |
There was a problem hiding this comment.
@zakiva should this also check if the pvc is bounded or not?
I think so since only then it would mean that the project was allocated a pv(else its just a request?).
https://kubernetes.io/docs/concepts/storage/persistent-volumes/#lifecycle-of-a-volume-and-claim
There was a problem hiding this comment.
I think there is no need to check because capacity represents the actual resources of the bounded volume. In case the claim is not bounded, capacity will be an empty hash.
|
@miq-bot remove_label wip |
miq-bot
changed the title
zeari
changed the title
zeari
force-pushed
the
container_storage
branch
from
0060000 to
be3dc46
Compare
|
Checked commit zeari@be3dc46 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
|
||
| it "calculates container storage when having zero persistent volume claims" do | ||
| derived_columns = described_class.fill_allocated_container_storage(project3) | ||
| expect(derived_columns[:derived_vm_allocated_disk_storage]).to eq(0) |
There was a problem hiding this comment.
note: projects with no pvc's or unbounded pvcs will have zero instead of nil.
|
@simon3z Ping |
|
@zeari please update patch to use recently added collected PVC requests. |
No and no, since we dont collect metrics for project directly. AFAIK We have only metric rollups for |
|
Closing until relevant again. |
Fill in
derived_vm_allocated_disk_storagein hourlyMetricRollupsfor container groups and container projects.@cben @moolitayer @zakiva please review.
cc @simon3z
@miq-bot add_label providers/containers, wip, enhancement, providers/metrics
Edit: Storage for pods was removed from this PR since in the case of many pods using the same pvc, no one specific pod was allocated the entire storage capacity.